gnachman / iTerm2 / 435
32%
master: 30%

LAST BUILD BRANCH: 3.0.6
DEFAULT BRANCH: master
Ran
Jobs 1
Files 361
Run time 25s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
435

push

travis-ci

gnachman 
Remove characters from hotkey descriptors since it was redundant.

Add setObjectsFromDictionary: to ProfileModel, iTermProfilePreferences, and iTermPreferencesBaseViewController , and use it when updating the hotkey prefs so only one notification gets posted and we don't unregister/register once per key.

Post a notification when a terminal window controller is created. This is used to calculate the siblings of a window controller before it's been saved in the iTermProfileHotKey's windowController field. Instead it gets saved in a windowControllerBeingBorn field, which is separate beacuse it's just a half-baked window controller that you can't do windowy things with yet without hitting weird problems since it e.g. has no sessions yet.

Fix bugs around auto hiding when there are multiple windows with the same hotkey.

Improve the behavior of shortcut input views. They now take precedence over window-switching keystrokes so you can bind a hotkey to cmd-opt-number.

When a hotkey is pressed the other iTermHotKey*s that have the same keypress are reported up from the carbon hotkey controller so multiple windows with the same hotkey can know about each other.

Fix a bug where the hotkey shortcut input field didn't set its stringValue when the pressed key was a hotkey elsewhere.

195 of 195 new or added lines in 14 files covered. (100.0%)

29640 of 92110 relevant lines covered (32.18%)

31.95 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
25.97
 1.08% sources/ProfilesKeysPreferencesViewController.m
1
0.0
 0.0% sources/iTermAppHotKey.m
3
0.0
 0.0% sources/iTermHotkeyPreferencesWindowController.m
5
34.65
 -0.41% sources/iTermPreferencesBaseViewController.m
5
45.16
 -2.57% sources/iTermProfilePreferencesBaseViewController.m
7
81.94
 -2.61% sources/iTermProfilePreferences.m
8
7.1
 -0.12% sources/iTermApplication.m
8
40.0
 -0.45% sources/iTermHotKeyProfileBindingController.m
10
40.85
 -0.46% sources/ProfileModel.m
12
0.0
 0.0% sources/iTermCarbonHotKeyController.m
13
0.0
 0.0% sources/iTermBaseHotKey.m
15
22.69
 0.95% sources/PseudoTerminal.m
40
0.0
 0.0% sources/iTermProfileHotKey.m
64
6.53
 -0.11% sources/iTermHotKeyController.m

Uncovered Existing Lines

Lines Coverage ∆ File
2
0.0
 0.0% sources/iTermProfileHotKey.m
2
81.94
 -2.61% sources/iTermProfilePreferences.m
6
22.02
 -0.15% sources/PTYTextView.m
7
22.69
 0.95% sources/PseudoTerminal.m
7
74.5
 2.68% sources/CharacterRunInline.h
12
40.0
 -0.45% sources/iTermHotKeyProfileBindingController.m
13
90.28
 0.69% sources/ITAddressBookMgr.h
31
6.53
 -0.11% sources/iTermHotKeyController.m
34
25.97
 1.08% sources/ProfilesKeysPreferencesViewController.m
35
10.64
 -1.27% sources/NSDictionary+iTerm.m
37
0.0
 0.0% sources/iTermCarbonHotKeyController.m
53
37.88
 -1.18% sources/PreferencePanel.m
68
31.07
 -0.7% sources/ProfilePreferencesViewController.m
70
0.0
 0.0% sources/iTermHotkeyPreferencesWindowController.m
71
21.74
 -17.73% sources/NSArray+iTerm.m
72
52.94
 2.61% sources/VT100GridTypes.h
81
43.56
 -0.6% sources/NSStringITerm.m
96
6.49
 0.56% sources/iTermKeyBindingMgr.m
107
16.39
 -5.39% sources/KeysPreferencesViewController.m
Jobs
ID Job ID Ran Files Coverage
1 435.1 361
32.18
 Travis Job 435.1
Source Files on build 435
Coverage ∆ File Lines Relevant Covered Missed Hits/Line