rust-bitcoin / rust-bitcoin / 8973396166

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2746: hashes: Modify trait bounds

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d094350230757afb3f0bf93cf49ea2a051153090">d09435023 hashes: Modify trait bounds (Tobin C. Harding)

Pull request description:

  Currently we require indexing trait bounds as well as `Borrow` on the `Hash` trait. We also already implement `AsRef`.

  It was observed that `Borrow<[u8]>` does not best describe what we want from the `Hash` trait implementor but rather `AsRef<[u8]>` does.

  Remove all the inexing trait bounds. Remove the `borrow::Borrow<[u8]>` trait bound. Add a `convert::AsRef<[u8]>` trait bound.

  This leaves the `Borrow<[u8]>` implementation for hashes created with `hash_newtype`, I'm not sure if this should be removed or not.

ACKs for top commit:
  apoelstra:
    ACK d094350230757afb3f0bf93cf49ea2a051153090 thanks! FWIW I think we might want to return the indexing traits one day, at least `[..]`, but we can do that post-1.0 and we have not gotten any complaints after removing them from the non-HMAC hashes, so maybe people are good with it as is.

Tree-SHA512: 2704a7e85bbe6e0fb5acd663be6104d813e

10 of 10 new or added lines in 3 files covered. (100.0%)

19192 of 23075 relevant lines covered (83.17%)

16800.85 hits per line