ocaml / dune / 26790

7%

Build Type

push

github

Committed by web-flow

Commit Message

Communicate READER to merlin for configured dialects (#8567)

* refactor: best effort to track orig module sources

This is going to be useful for more granular merlin configs.

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* refactor: per file merlin configs, communicate merlin reader

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* test: promote merlin tests

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* test: add merlin/dialect.t tests

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* test: add a test focusing on merlin's configuration various granularity levels

Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
Signed-off-by: Andrey Popp <8mayday@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>

* test: tweak the prev commit (to be squashed)

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* wip: Module.File.t not to encode orig_path

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* merlin: lookup fallback with extensionless filename

Relying on `.ml` extension present is not something we can do, instead
store same config with and without extension and on lookup do a fallback
with no extension.

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* Apply suggestions from code review

Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Andrey Popp <8mayday@gmail.com>

* Extract `handle_ml_kind` to the outside scope.

Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Andrey Popp <8mayday@gmail.com>

* Use Filename.Extension.t for file extensions

Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Andrey Popp <8mayday@gmail.com>

* tests: update merlin/dialect tests

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* More descriptive naming in Module

Signed-off-by: Andrey Popp <8mayday@gmail.com>

* promote tests

due to dune 3.16

Signed-off-by: Andrey Popp <8mayday@gmail.com>

... (continued)

Run Details

2 of 68 new or added lines in 3 files covered. (2.94%)

2 existing lines in 1 file now uncovered.

2907 of 42077 relevant lines covered (6.91%)

27071.82 hits per line