gimli-rs / object / 8947502904

56%

Build Type

push

github

Committed by web-flow

Commit Message

write/macho: ensure Mach-O subsections are not zero size (#676)

For Mach-O, `add_symbol_data` now ensures that the symbol size
is at least 1 when subsections via symbols are enabled.
This change was made to support linking with ld-prime. It is also
unclear how this previously managed to work with ld64.

`write::Object::add_subsection` no longer enables subsections
via symbols for Mach-O. Use `set_subsections_via_symbols` instead.
This change was made because Mach-O subsections are all or nothing,
so this decision must be made before any symbols are added.

`write::Object::add_subsection` no longer adds data to the subsection.
This change was made because it was done with `append_section_data`,
but this is often not the correct way to add data to the subsection.
Usually `add_symbol_data` is a better choice.

Run Details

7 of 18 new or added lines in 3 files covered. (38.89%)

7 existing lines in 4 files now uncovered.

8961 of 16387 relevant lines covered (54.68%)

1.56 hits per line