uber / cadence-java-client / 2304

61%

master: 80%

Build Type

Pull #890

buildkite

Committed by natemort

Commit Message

Lock TestWorkflowStoreImpl when listing workflows

This is the only path to the backing histories map that isn't locked. When running a test containing multiple child workflows in parallel where one child workflow attempts to call listWorkflows I'm able to consistently reproduce a concurrent modification exception.

Despite being a change to locking, this change is rather low risk. The lock is reentrant and there are no other locks acquired while holding this lock, so there's no chance of deadlock. In addition, this codepath isn't use internally at all. It exists only to implement ListOpenWorkflowExecutions and ListClosedWorkflowExecutions on the client, allowing test code to make these RPCs. This is likely why it hasn't been caught before.

Pull Request Pull Request #890: Lock TestWorkflowStoreImpl when listing workflows

Run Details

43 of 46 new or added lines in 1 file covered. (93.48%)

15 existing lines in 7 files now uncovered.

11951 of 19458 relevant lines covered (61.42%)

0.61 hits per line