8938539775
74%
BABEL_5_X_DEV: 77%

Ran 03 May 2024 12:42PM UTC

Jobs 1

Files 114

Run time 1min

Badge

Embed ▾

Committed 03 May 2024 11:54AM UTC coverage: 73.045%. Remained the same

Build # 8938539775

Build Type

push

github

Committed by

web-flow

Commit Message

Fix searchpath handling for tsql udfs inside fmgr (#2536)

Currently we override the search_path for pltsql UDFs directly using the GUC variable & avoid set_config. This leads to crash if there was another set_config('search_path... when we were in this overridden state. Reason for crash is that the new set_config call may push the current value (the one we set in fmgr) onto GUC stack. Now it pssoble that we exit the function call and released fcache, but fcache->prosearchpath is still referenced in GUC stack.

To fix this we fallback to using set_config for setting the search_path & skip the check hook for search path when setting from inside fmgr which helps with performance. Also increase the GUC nest level since GUC_ACTION_SAVE is not possible on top of GUC_ACTION_SET (user set), which is possible in this case. New nest level also means that we do not have to reset the search path at the end of execution and let AtEOXact_GUC(commit=true) handle it.

We also move the set search path block in fmgr inside TRY, to ensure we reset the skip check search path variable in case of errors.

Issues Resolved : [BABEL-4877]

Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/353

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

Run Details

41453 of 56750 relevant lines covered (73.04%)

103253.23 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	8938539775.1	03 May 2024 12:42PM UTC	114	73.04	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 8938539775
74%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8938539775

babelfish-for-postgresql / babelfish_extensions / 8938539775 74% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8938539775

babelfish-for-postgresql / babelfish_extensions / 8938539775
74%
BABEL_5_X_DEV: 77%

README BADGES
x