binary-com / deriv-app / 8937956190

54%

push

github

[P2PS] / Ameerul / P2PS-2642 No Confirm popup is shown when signed in. 'a.showModal is not a function' console error appears (#14719)

* chore: added undefined check for showModal

* chore: add ? for showModal in app.jsx

* chore: check if showModal is a function

* chore: moved order confirm handler to orders file

* chore: removed useState and general_store.showModal

* chore: check order_store.verification_code and location from useLocation

* chore: set verification code in app, moved show modal function in reaction

* fix: failing orders.spec.js test case, deleted duplicate test case

* chore: passed p2p_confirm_order directly to verify email

* fix: verify email modal keeps appearing

* fix: confirm button is not clickable, user cant confirm order

16669 of 45130 branches covered (36.94%)

Branch coverage included in aggregate %.

13 of 25 new or added lines in 7 files covered. (52.0%)

27524 of 63901 relevant lines covered (43.07%)

11.73 hits per line