openSUSE / agama / 8938198596

72%

Build Type

push

github

Committed by web-flow

Commit Message

web: Reuse devices (#1165)

Implement feature for reusing an existing device (i.e., allow formatting
a block device or mounting a file system). Main changes:

* Redesign the dialog for changing location:
* Shows a table with all the devices that can be selected as location
for the volumes.
* Allows selecting how to allocate the file system at selected device
(create partition, create dedicated LVM, format, mount).
* Add a menu option in the table of volumes for resetting the location
(i.e., to use the installation device instead of a custom location).

Note: We have detected some problems with the UI for changing location
implemented in this PR:

* The table is scrollable. If there are too many devices, then there is
a chance of overlooking some devices if you don't realize about the
scroll.
* Having a table and group of radios at the end looks quite
overwhelming. The very same information could be provided in a simpler
way.
* Ideally, this change location option should be integrated in the form
of the volume.

Check some ideas in the thread of this PR and at
https://github.com/openSUSE/agama/discussions/1176.

<details>
<summary>Toggle screenshots</summary> 
 
![localhost_8080_
(44)](https://github.com/openSUSE/agama/assets/1112304/e93882df-a8ab-4c48-8df9-63154011adb0)

![localhost_8080_
(45)](https://github.com/openSUSE/agama/assets/1112304/f9cd0c6f-484c-4903-8961-94169fffe9b4)

</details>

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

124 of 132 new or added lines in 15 files covered. (93.94%)

92 existing lines in 12 files now uncovered.

18535 of 24475 relevant lines covered (75.73%)

34.78 hits per line