• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ethereum / pydevp2p / 254
88%

Build:
DEFAULT BRANCH: develop
Ran 23 Jun 2016 05:53PM UTC
Jobs 2
Files 17
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
254

push

travis-ci

ulope
Fix critical unintentional variable name reuse

In `devp2p.discovery.recv_neighbours()` the variable `node` (ostensibly
containing the sender node) was reused as a temporary variable inside a 
for loop. 

Depending on the order of the `neighbours_lst` this lead in many cases
to neighbour information being attributed to the wrong sender node.

Thanks to @konradkonrad for the pair debugging :)

Refs: HydraChain/hydrachain#73

5 of 5 new or added lines in 1 file covered. (100.0%)

1982 of 2280 relevant lines covered (86.93%)

1.68 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
devp2p/__init__.py
1
100.0
devp2p/protocol.py
2
100.0
devp2p/app.py
3
100.0
devp2p/peer.py
4
100.0
devp2p/app_helper.py
11
100.0
devp2p/peermanager.py
16
100.0
devp2p/discovery.py
47
100.0
devp2p/kademlia.py
Jobs
ID Job ID Ran Files Coverage
1 254.1 23 Jun 2016 05:53PM UTC 0
86.14
Travis Job 254.1
2 254.2 23 Jun 2016 05:55PM UTC 0
81.84
Travis Job 254.2
Source Files on build 254
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #254
  • c492b009 on github
  • Prev Build on develop (#250)
  • Next Build on develop (#255)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc