#4035

Committed 02 May 2024 09:39AM UTC coverage: 48.839%. Remained the same

Build # #4035

Build Type

push

github

Committed by

adangel

Commit Message

[java] Fix #4912 - grammar for TWR allows this expression (#4934)

Merge pull request #4934 from oowekyala:issue4912-java-grammar-fix

Run Details

32579 of 72990 branches covered (44.63%)

Branch coverage included in aggregate %.

29 of 31 new or added lines in 4 files covered. (93.55%)

2 existing lines in 1 file now uncovered.

68507 of 133987 relevant lines covered (51.13%)

0.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.75

/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTResource.java

/**
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.java.ast;

import org.checkerframework.checker.nullness.qual.Nullable;

import net.sourceforge.pmd.lang.ast.Node;
import net.sourceforge.pmd.lang.java.ast.internal.PrettyPrintingUtil;

/**
 * A resource of a {@linkplain ASTTryStatement try-with-resources}. This contains another
 * node that represents the resource, according to the grammar below.
 *
 * <p>In the case of concise try-with resources, the subexpressions are
 * required to be only field accesses or variable references to compile.
 *
 * <pre class="grammar">
 *
 * Resource ::= {@link ASTLocalVariableDeclaration LocalVariableDeclaration}
 *            | {@link ASTPrimaryExpression PrimaryExpression}
 *
 * </pre>
 */
public final class ASTResource extends AbstractJavaNode {

    ASTResource(int id) {
        super(id);
    }


    @Override
    protected <P, R> R acceptVisitor(JavaVisitor<? super P, ? extends R> visitor, P data) {
        return visitor.visit(this, data);
    }

    /**
     * Returns true if this appears as an expression, and not as a
     * local variable declaration.
     */
    public boolean isConciseResource() {
        return getChild(0) instanceof ASTExpression;
    }

    /**
     * Gets the name with which the resource can be accessed in the
     * body of the try statement. If this is a {@linkplain #isConciseResource() concise resource},
     * then returns the sequence of names that identifies the expression.
     * If this has a local variable declaration, then returns the name
     * of the variable.
     *
     * @deprecated Since 7.1.0. This method is not very useful because the expression
     *          might be complex and not have a real "name". In this case we return the
     *          expression pretty printed.
     */
    @Deprecated
    public String getStableName() {
        if (isConciseResource()) {
            return PrettyPrintingUtil.prettyPrint(getInitializer()).toString();
        } else {
            return asLocalVariableDeclaration().iterator().next().getName();
        }
    }

    @Nullable
    public ASTLocalVariableDeclaration asLocalVariableDeclaration() {
        return AstImplUtil.getChildAs(this, 0, ASTLocalVariableDeclaration.class);
    }


    /**
     * Returns the initializer of the expression.
     * If this is a concise resource, then returns that expression.
     * If this is a local variable declaration, returns the initializer of
     * the variable.
     */
    public ASTExpression getInitializer() {
        Node c = getChild(0);
        if (c instanceof ASTExpression) {
            return (ASTExpression) c;
        } else {
            return ((ASTLocalVariableDeclaration) c).iterator().next().getInitializer();
        }
    }
}

1	/**
2	* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3	*/
4
5	package net.sourceforge.pmd.lang.java.ast;
6
7	import org.checkerframework.checker.nullness.qual.Nullable;
8
9	import net.sourceforge.pmd.lang.ast.Node;
10	import net.sourceforge.pmd.lang.java.ast.internal.PrettyPrintingUtil;
11
12	/**
13	* A resource of a {@linkplain ASTTryStatement try-with-resources}. This contains another
14	* node that represents the resource, according to the grammar below.
15	*
16	* <p>In the case of concise try-with resources, the subexpressions are
17	* required to be only field accesses or variable references to compile.
18	*
19	* <pre class="grammar">
20	*
21	* Resource ::= {@link ASTLocalVariableDeclaration LocalVariableDeclaration}
22	* \| {@link ASTPrimaryExpression PrimaryExpression}
23	*
24	* </pre>
25	*/
26	public final class ASTResource extends AbstractJavaNode {
27
28	ASTResource(int id) {
29	super(id);	1✔
30	}	1✔
31
32
33	@Override
34	protected <P, R> R acceptVisitor(JavaVisitor<? super P, ? extends R> visitor, P data) {
35	return visitor.visit(this, data);	1✔
36	}
37
38	/**
39	* Returns true if this appears as an expression, and not as a
40	* local variable declaration.
41	*/
42	public boolean isConciseResource() {
43	return getChild(0) instanceof ASTExpression;	1✔
44	}
45
46	/**
47	* Gets the name with which the resource can be accessed in the
48	* body of the try statement. If this is a {@linkplain #isConciseResource() concise resource},
49	* then returns the sequence of names that identifies the expression.
50	* If this has a local variable declaration, then returns the name
51	* of the variable.
52	*
53	* @deprecated Since 7.1.0. This method is not very useful because the expression
54	* might be complex and not have a real "name". In this case we return the
55	* expression pretty printed.
56	*/
57	@Deprecated
58	public String getStableName() {
UNCOV 59	if (isConciseResource()) {	×
NEW 60	return PrettyPrintingUtil.prettyPrint(getInitializer()).toString();	×
61	} else {
UNCOV 62	return asLocalVariableDeclaration().iterator().next().getName();	×
63	}
64	}
65
66	@Nullable
67	public ASTLocalVariableDeclaration asLocalVariableDeclaration() {
68	return AstImplUtil.getChildAs(this, 0, ASTLocalVariableDeclaration.class);	1✔
69	}
70
71
72	/**
73	* Returns the initializer of the expression.
74	* If this is a concise resource, then returns that expression.
75	* If this is a local variable declaration, returns the initializer of
76	* the variable.
77	*/
78	public ASTExpression getInitializer() {
79	Node c = getChild(0);	1✔
80	if (c instanceof ASTExpression) {	1✔
81	return (ASTExpression) c;	1✔
82	} else {
83	return ((ASTLocalVariableDeclaration) c).iterator().next().getInitializer();	1✔
84	}
85	}
86	}

pmd / pmd / #4035

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous