Qiskit / qiskit / 8912008593

88%

Build Type

push

github

Committed by web-flow

Commit Message

Reject vars in `QuantumCircuit.to_instruction` and `to_gate` (#12207)

* Reject vars in `QuantumCircuit.to_instruction` and `to_gate`

`QuantumCircuit.to_gate` may be able to support `input` variables that
are angle-typed at some point in the future, but that's very limited and
not immediately on the roadmap.

`QuantumCircuit.to_instruction` does have a natural way to support both
`input` vars (they become function arguments) and declared vars (since
they're completely internal to the function body), but those are
currently rejected because we don't have a way of specifying function
signatures / calling functions yet and we don't have a neat complete
story around unrolling variables into circuits yet (where there may be
naming clashes), especially through transpilation.  This opts to raise
the errors immediately, with alternatives where possible, rather than
letting things _kind of_ work.

* Remove now-unused loop

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

12 existing lines in 4 files now uncovered.

61498 of 68684 relevant lines covered (89.54%)

217407.05 hits per line