unicode-org / icu4x / 8881920599

73%

Build Type

push

github

Committed by web-flow

Commit Message

Split datetime error paths (#4732)

https://github.com/unicode-org/icu4x/issues/4336

What this PR does
- Stops converting datetime errors into fmt errors
- Use fallback values to continue writing when an error occurs
- Replaces `Writeable` by `TryWriteable` in neo
- Uses lossy mode in non-neo Writeable implementations

What this PR doesn't do
- Use correct gigo values. For now it writes `<ICU4X ERROR>` everywhere.
A domain expert should replace these by sensible values
- Use a narrower error type than `DatetimeError` for `TryWriteable`

Run Details

236 of 318 new or added lines in 7 files covered. (74.21%)

7 existing lines in 5 files now uncovered.

53166 of 69582 relevant lines covered (76.41%)

497074.16 hits per line