ovn-org / ovn-kubernetes / 8879117663

52%

master: 53%

Build Type

Pull #4067

github

Committed by arghosh93

Commit Message

Reuse node-subnet from cache if exists

This PR is to return an already allocated subnet instead of
creating a new one if a combination of subnet and node name
already exists in the cache.

This PR is to stop multiple allocation of node-subnet from
ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not
reach default BackOff[1] time limit for retry framework and meanwhile
syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>

Pull Request Pull Request #4067: Reuse node-subnet from cache if exists

Run Details

7 of 9 new or added lines in 1 file covered. (77.78%)

21 existing lines in 5 files now uncovered.

27784 of 53022 relevant lines covered (52.4%)

102.12 hits per line