8877339957
92%

Ran 29 Apr 2024 11:07AM UTC

Jobs 1

Files 156

Run time 1min

Badge

Embed ▾

Committed 29 Apr 2024 10:51AM UTC coverage: 90.12% (+0.02%) from 90.096%

Build # 8877339957

Build Type

push

github

Committed by

web-flow

Commit Message

feat: add page_number to metadata in DocumentSplitter (#7599)

* Add the implementation for page counting used in the v1.25.x branch. It should work as expected in issue #6705.

* Add tests that reflect the desired behabiour. This behabiour is inffered from the one it had on Haystack 1.x
Solve some minor bugs spotted by tests.

* Update docstrings.

* Add reno.

* Update haystack/components/preprocessors/document_splitter.py

Update docstring from suggestion

Co-authored-by: David S. Batista <dsbatista@gmail.com>

* solve suggestion to improve readability

* fragment tests

* Update haystack/components/preprocessors/document_splitter.py

Co-authored-by: David S. Batista <dsbatista@gmail.com>

* Update .gitignore

* Update .gitignore

* Update add-page-number-to-document-splitter-162e9dc7443575f0.yaml

* blackening

---------

Co-authored-by: David S. Batista <dsbatista@gmail.com>

Run Details

6330 of 7024 relevant lines covered (90.12%)

0.9 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	98.57	0.46%	components/preprocessors/document_splitter.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	8877339957.1	29 Apr 2024 11:07AM UTC	156	90.12	GitHub Action Run

deepset-ai / haystack / 8877339957
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8877339957

deepset-ai / haystack / 8877339957 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8877339957

deepset-ai / haystack / 8877339957
92%

README BADGES
x