hardbyte / python-can / 8876612530

71%

Build Type

push

github

Committed by web-flow

Commit Message

Invert default value logic for BusABC._is_shutdown. (#1774)

The destructor of BusABC gives a warning when shutdown() was not
previously called on the object after construction.  However, if the
construction fails (e.g. when the derived bus class constructor raises
an exception), there is no way to call shutdown() on the unfinished
object, and it is not necessary either.

Initialize the _is_shutdown flag to False initially and flip it to
True only when the parent class constructor runs, which usually
happens last in derived classes.  That avoids the shutdown warning for
objects that failed to initialize at all.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

5 existing lines in 3 files now uncovered.

7402 of 10507 relevant lines covered (70.45%)

13.36 hits per line