c-ares / c-ares / #807

92%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Add observability into DNS server health via a server state callback, invoked whenever a query finishes (#744)

**Summary**

This PR adds a server state callback that is invoked whenever a query to
a DNS server finishes.

The callback is invoked with the server details (as a string), a boolean
indicating whether the query succeeded or failed, flags describing the
query (currently just indicating whether TCP or UDP was used), and
custom userdata.

This can be used by user applications to gain observability into DNS
server health and usage. For example, alerts when a DNS server
fails/recovers or metrics to track how often a DNS server is used and
responds successfully.

**Testing**

Three new regression tests `MockChannelTest.ServStateCallback*` have
been added to test the new callback in different success/failure
scenarios.

Fix By: Oliver Welsh (@oliverwelsh)

Run Details

53 of 70 new or added lines in 3 files covered. (75.71%)

1 existing line in 1 file now uncovered.

8419 of 10443 relevant lines covered (80.62%)

3841.9 hits per line