Ouranosinc / xscen / 8850506105

90%

push

github

Drop build_reduction_data and refactor the reduce module (#386)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
* ``xs.reduce_ensemble`` will now call
``xclim.ensembles.create_ensemble`` and ``xclim.ensembles.make_critera``
if required.

### Does this PR introduce a breaking change?
* The ``xscen.reduce`` module has been abandoned.
* ``build_reduction_data`` has been made redundant by
``xclim.ensembles.make_critera`` and will be removed in a future
release.
* ``xscen.reduce.reduce_ensemble`` has been moved to
``xscen.ensembles.reduce_ensemble``, as a module was no longer
necessary.

### Other information:

21 of 21 new or added lines in 1 file covered. (100.0%)

2977 of 3993 relevant lines covered (74.56%)

5.85 hits per line