rust-bitcoin / rust-bitcoin / 8849264030

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2720: CI: Enable sync-labels for labeler

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a03bc2e5b100b376876d2d5ab7425d7784c12930">a03bc2e5b CI: Enable sync-labels for labeler (Tobin C. Harding)

Pull request description:

  The `labeler` job has an input `sync-labels` (default `false`) that configures:

  > Whether or not to remove labels when matching files are reverted or no
  > longer changed by the PR

  ref: https://github.com/actions/labeler

  Currently we are using the default which means labels are not synced when a PR is modified.

  Example

  A PR initially touches the `hashes` and `bitcoin` crates and the labeler action adds `C-hashes` and `C-bitcoin`. Later, a force push removes the changes to `hashes`, the labeler will not remove the `C-hashes` label. Now the labels are incorrect.

  Note on `pull_request_target`:

  We use `on: pull_request_target`, this means the action is run in the target branch not in the PR branch. So the changes in this patch are not run when this PR is pushed up. Therefore we cannot test this patch but have to merge it blindly - please review carefully.

  Some further security notes that I learned while doing this patch. The `pull_request_target` has access to GitHub secrets, and in `manage-pr.yaml` we run `./contrib/gen_label_config.sh`. This is safe because its the version of this script on `master` that is run not the version in the PR (so a malicious attacker cannot patch `gen_label_config.sh` and have it be run). However we need to be aware that we do not accidentally merge some funky shell and inadvertently leak secrets.

ACKs for top commit:
  storopoli:
    ACK a03bc2e5b100b376876d2d5ab7425d7784c12930
  apoelstra:
    ACK a03bc2e5b100b376876d2d5ab7425d7784c12930

Tree-SHA512: 4082e52edc1d6ae55517dd2ec3ffb35965f

19195 of 23090 relevant lines covered (83.13%)

16809.0 hits per line