openSUSE / agama / 8834584146

72%

push

github

Adapt to recent changes on Y2Storage::GuidedProposal (#1164)

## Problem

Agama uses the `Y2Storage` strategy to find space called
`:bigger_resize`. That strategy was found to be inconsistent, so it was
slightly modified.

See more details at https://github.com/yast/yast-storage-ng/pull/1382

## Solution

This pull request adapts Agama to the new approach, in which the space
actions are only expected for partitions (and maybe in the future for
logical volumes), but not for whole disks.

1) The actions generated for the pre-defined policies do not longer
include the disks, only partitions.

2) The "Find Space" form only offers the action selector for the
partitions. In the case of disks without partitions, some static texts
are added to help the user understand what can happen with the content
of the disk.


![partition_actions](https://github.com/openSUSE/agama/assets/3638289/d1996c0b-a8de-4cea-8a76-14d8b3240199)

Note we plan to rethink the whole interface of "Find Space" in the short
term. This pull request only aims to keep the UI consistent with the new
logic in the proposal, while the bigger changes arrive.

## Testing

- Unit tests adapted.
- Tested manually together with
https://github.com/yast/yast-storage-ng/pull/1382

1834 of 2684 branches covered (68.33%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 4 files covered. (100.0%)

18217 of 24143 relevant lines covered (75.45%)

31.21 hits per line