uber / tchannel-go / 2123
87%
dev: 88%

LAST BUILD BRANCH: delayed_frame_alloc
DEFAULT BRANCH: dev
Ran
Jobs 3
Files 42
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2123

push

travis-ci

prashantv 
relay: Fix use-after-release on finishesCall(frame)

The MemProtectFramePool causes the following crash in
TestRelayConcurrentCalls:

unexpected fault address 0x40f7032
fatal error: fault
[signal 0xa code=0x2 addr=0x40f7032 pc=0xb8484]

goroutine 424 [running]:
runtime.throw(0x631d70, 0x5)
        /usr/local/Cellar/go/1.6.2/libexec/src/runtime/panic.go:547 +0x90 fp=0xc8201c3c38 sp=0xc8201c3c20
runtime.sigpanic()
        /usr/local/Cellar/go/1.6.2/libexec/src/runtime/sigpanic_unix.go:21 +0x1e4 fp=0xc8201c3c88 sp=0xc8201c3c38
github.com/uber/tchannel-go.finishesCall(0x40f7000, 0x40f7000)
        /Users/prashant/gocode/src/github.com/uber/tchannel-go/relay_messages.go:162 +0x14 fp=0xc8201c3c90 sp=0xc8201c3c88
github.com/uber/tchannel-go.(*Relayer).handleNonCallReq(0xc820238d80, 0x40f7000, 0x0, 0x0)
        /Users/prashant/gocode/src/github.com/uber/tchannel-go/relay.go:353 +0x1f7 fp=0xc8201c3d90 sp=0xc8201c3c90
github.com/uber/tchannel-go.(*Relayer).Relay(0xc820238d80, 0x40f7000, 0x0, 0x0)
        /Users/prashant/gocode/src/github.com/uber/tchannel-go/relay.go:193 +0x59 fp=0xc8201c3e20 sp=0xc8201c3d90
github.com/uber/tchannel-go.(*Connection).handleFrameRelay(0xc820448a80, 0x40f7000, 0xc820030100)
        /Users/prashant/gocode/src/github.com/uber/tchannel-go/connection.go:760 +0x5c fp=0xc8201c3ef0 sp=0xc8201c3e20
github.com/uber/tchannel-go.(*Connection).readFrames(0xc820448a80, 0x46)
        /Users/prashant/gocode/src/github.com/uber/tchannel-go/connection.go:749 +0x326 fp=0xc8201c3f90 sp=0xc8201c3ef0

This points out exactly where we tried to access the frame (relay.go:353 calling finishesRelay).

3864 of 4446 relevant lines covered (86.91%)

11272.22 hits per line

Jobs
ID Job ID Ran Files Coverage
2 2123.2 (TEST_TIMEOUT_SCALE=20) 42
86.02
 Travis Job 2123.2
3 2123.3 (TEST_TIMEOUT_SCALE=20) 42
86.32
 Travis Job 2123.3
4 2123.4 (TEST_TIMEOUT_SCALE=20) 42
86.44
 Travis Job 2123.4
Source Files on build 2123
Coverage ∆ File Lines Relevant Covered Missed Hits/Line