IntelPython / dpctl / 8809953212

86%

Build Type

push

github

Committed by web-flow

Commit Message

Fixes element-wise comparisons of mixed signed-unsigned integer inputs (#1650)

* Align `not_equal` type map to other comparisons

Overloads for combinations of complex and real valued floats are unnecessary, as floats can be safely cast to complex

* Comparisons with signed and unsigned integers behave correctly

Comparions between signed and unsigned integer data previously did not work correctly in some cases, as signed integers could be promoted to uint64 if one input was uint64

Additionally, `-1 < x` for some `x` with unsigned integer data type would always fail, as the -1 would initialize an array of `x.dtype` which would always underflow, leading to undefined behavior

These problems were addressed by adding signed and unsigned 64-bit integer combinations to the type maps for the comparisons, and adding constexpr branches to the comparisons between mixed-kind integers

* Apply suggested docstring for get_array_dtype_scalar_type_resolver_function

* Refactor `isinstance` checks for any weak types into `_is_weak_dtype` utility function

Per suggestion by @oleksandr-pavlyk

* Added tests for comparing unsigned integer arrays to negative integer arrays and Python scalars

Run Details

3575 of 4060 branches covered (88.05%)

Branch coverage included in aggregate %.

51 of 53 new or added lines in 3 files covered. (96.23%)

2 existing lines in 1 file now uncovered.

10763 of 12193 relevant lines covered (88.27%)

8735.75 hits per line