rust-bitcoin / rust-bitcoin / 8800759283

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2710: Document the *_encode_signing_data_to functions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/dc8b900dec46bc6ff07e35db39836a51ab06d464">dc8b900de Document the *_encode_signing_data_to functions (Tobin C. Harding)

Pull request description:

  If one writes signing data using one of the two
  `*_encode_signing_data_to` functions then creating the message to sign is slightly nuanced and different for each of the functions. For Taproot one must use a specific tagged hash and for ECDSA one must use a sha256d hash.

  Add documentation that explains the hashing requirements for each function.

  Close: #2703

ACKs for top commit:
  apoelstra:
    ACK dc8b900dec46bc6ff07e35db39836a51ab06d464 we maybe should say specifically which tagged hash, but I think this is fine

Tree-SHA512: bfbabb8225f304d027aacfa8e118b6c4b41

19195 of 23090 relevant lines covered (83.13%)

16844.74 hits per line