Clinical-Genomics / cg / 8798563155

86%

Build Type

push

github

Committed by web-flow

Commit Message

Remove BclConverter usage from FlowCellDirectoryData (#3164)(patch)

## Description
Stop using `bcl_converter` as parameter fo any function, as everything uses BCLConvert now. As a consequence, the constants for "bcl2fastq" and "bcl_convert" are not used anymore, therefore removed.

### Changed

- The function `get_flow_cell_samples` from LIMS API no longer receives the FlowCellSample model, as it uses `FlowCellBclConvertSample` only.
- This causes `_get_flow_cell` and `get_or_create_sample_sheet` in the sample sheet API not need the bclconvert as parameter, so it is removed.
- Remove `bcl_converter` from parameter of the `FlowCellDirectoryData` model, as it uses only BCLConvert.

### Fixed

- All usages of above functions, removing bclconvert parameter

Run Details

10 of 12 new or added lines in 4 files covered. (83.33%)

3 existing lines in 2 files now uncovered.

19477 of 23082 relevant lines covered (84.38%)

0.84 hits per line