IntelPython / dpctl / 8776207628

86%

push

github

Type promotion for `indices` arrays and casting `vals` in integer indexing (#1647)

* Tweaks to advanced integer indexing

Setting items in an array now casts the right-hand side to the array data type when the data types differ

Setting and getting from an empty axis with non-empty indices now throws `IndexError`

* Integer advanced indexing now promotes indices arrays

* `put` now casts `vals` when the data type differs from `x`

Fixes `take` and `put` being used on non-empty axes with non-empty indices

Also adds a note to `put` about race conditions for non-unique indices

* Adds tests for indexing array casting for indices and values

* Fixes range when checking for empty axes in _take/_put_multi_index

Also corrects error raised in _put_multi_index when attempting to put into indices along an empty axis

* Changes per PR review

3583 of 4067 branches covered (88.1%)

Branch coverage included in aggregate %.

57 of 62 new or added lines in 2 files covered. (91.94%)

10722 of 12150 relevant lines covered (88.25%)

8760.87 hits per line