Gallopsled / pwntools / 8775368710

74%

Build Type

push

github

Committed by web-flow

Commit Message

Return buffered data on first EOF in tube.readline() (#2376)

* Return buffered data on first EOF in tube.readline()

When there is still data available in the tube buffer when an EOFError occurs in
`tube.recvline()`, return that data even though it doesn't contain a newline.
The next time `tube.recvline()` is called afterwards will raise EOFError normally.

This behavior is in line with the GNU readline implementation and avoids
loss of data. It allows `tube.stream()` to print everything that's received before
the receiving end terminates.

A new warning is logged when data is returned due to an EOF informing
about the lack of the trailing newline character.

Fixes #2366

* Update CHANGELOG

* Add context.throw_eof_on_incomplete_line

Allow to control the behavior of `tube.recvline` and
be able to suppress the new warning.

* Cleanup docs

Run Details

4651 of 7430 branches covered (62.6%)

10 of 11 new or added lines in 2 files covered. (90.91%)

6 existing lines in 3 files now uncovered.

13061 of 17636 relevant lines covered (74.06%)

0.74 hits per line