TuringLang / Turing.jl / 8771748446

76%

main: 84%

Build Type

push

github

Committed by web-flow

Commit Message

New Gibbs sampler using `condition` (#2099)

* initial work on the new gibbs sampler

* added tests for the new Gibbs sampler

* added tests for new Gibbs

* new Gibbs is now sampling (correctly) sequentially

* let's not overload merge just yet

* export GibbsV2 + added more samplers to the tests

* added TODO comment

* removed lots of varinfo related merging functionality that is now
available in DynamicPPL

* shifting some code around

* removed redundant constructor for GibbsV2

* added GibbsContext which is similar to FixContext but also computes
the log-prob of the fixed variables

* adopted the rerun mechanism in Gibbs for GibbsV2, thus fixing the
issues with some of the tests for GibbsV2

* broken tests are no longer broken

* fix issues with dot_tilde_* impls for GibbsContext

* fix for dot_tilde_assume when using GibbsContext

* fixed re-running of models for Gibbs sampling properly this time

* added new gibbs to tests

* added some further comments on why we need `GibbsContext`

* went back to using `DynamicPPL.condition` rather than using custom
`GibbsContext` while we wait for
https://github.com/TuringLang/DynamicPPL.jl/pull/563 to be merged

* add concrete comment about reverting changes for `gibbs_condition`

* Update test/mcmc/gibbs_new.jl

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* fixed recursive definition of `condition` varinfos

* use `fix` instead of `condition`

* Revert "use `fix` instead of `condition`"

This reverts commit f87e2d119.

* rmeoved unnused symbol

* Revert "went back to using `DynamicPPL.condition` rather than using custom"

This reverts commit 53bd7072d.

* bump compat entry of DynamicPPL so we can overload acclogp!

* update assume for SMC samplers to make use of new `acclogp!`

* added proper impl of acclogp!! for SMC samplers + made accessing
task local v... (continued)

Run Details

0 of 154 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

0 of 1511 relevant lines covered (0.0%)

0.0 hits per line