lslezak / agama / 8753116914

81%

Build Type

push

github

Committed by web-flow

Commit Message

web: Allow opening popups with "stable" size (#1156)

Although the (ab)use of popup/modal dialog has been avoided as much as
possible, they still being a valid resource for some use cases. However,
they can become a bit annoying when holding _dynamic_ content and users
interactions makes them change their size.

To bypass such a problem, two props has been added to the Agama
core/Popup component: `blockSize` and `inlineSize`. In a first
iteration, both accepts "auto", "small", "medium", and "large" values,
setting a _stable size_ on the corresponding axis that it's calculated
with respect to the size of viewport (except when using "auto", which
actually means _no stable size_).

As a side effect, in order to have more control on the sizing, the
PF/Modal `variant` prop is being ignored.

Coverage Stats

1847 of 2691 branches covered (68.64%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

18260 of 24179 relevant lines covered (75.52%)

31.5 hits per line