realm / realm-core / 2238

91%

Build Type

push

Evergreen

Committed by web-flow

Commit Message

Fix a race condition in Promise (#7602)

Promise needs to update `m_shared_state` before fulfilling the promise, as
`Future::get()` on another thread could return before the write occurs. If the
Promise is destroyed immediately after `get()` returns, the destructor could
then read the non-null value of `m_shared_state` before the write happens and
attempt to report a broken promise error, which hits an assertion.

Run Details

94882 of 175978 branches covered (53.92%)

21 of 21 new or added lines in 2 files covered. (100.0%)

50 existing lines in 7 files now uncovered.

243401 of 265120 relevant lines covered (91.81%)

5679155.3 hits per line