stacklok / minder / 8737078489

53%

Build Type

push

github

Committed by web-flow

Commit Message

Don't use SELECT * when joining profile tables (#3130)

This patch has no functional changes, it is just a cleanup in our Go
database models that I didn't want to send before the recent release.

If sqlc generates a model for a query that joins over two tables, it
autogenerates column names that are represented as structure members, so
you end up with a single structure with members such as `ID` and `ID_2`.

This can be confusing and invite bugs. It's much cleaner to use
`sqlc.embed` to make sure that each table is represented by a separate
attribute in the models.

Run Details

0 of 19 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

8320 of 17282 relevant lines covered (48.14%)

37.33 hits per line