018eedc4-642b-49ce-be74-b8649f645074
72%

Ran 17 Apr 2024 08:56PM UTC

Jobs 1

Files 673

Run time 1min

Badge

Embed ▾

Committed 17 Apr 2024 08:34PM UTC coverage: 67.406% (-0.004%) from 67.41%

Build # 018eedc4-642b-49ce-be74-b8649f645074

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Bugfix for enumer in go 1.22 (#5915)

Enumer is currently crashing if `make go-generate` is run with Go 1.22: https://github.com/alvaroloes/enumer/issues/71
Temporal helpfully found an easy fix: https://github.com/temporalio/sdk-go/issues/1382
For the underlying cause: https://github.com/golang/go/issues/62167
So I've mimicked that by just doing a `go get golang.org/x/tools@latest` in the tools-module.

And now `make clean` -> `GOTOOLCHAIN=[go1.20.1 or go1.22.1] make go-generate` both work correctly.
(you need Go 1.21 or newer to use GOTOOLCHAIN.  highly recommended!)

Since this only affects build-time tools and doesn't change any generated code, it seems trivially safe, but I have not checked what all has changed in golang.org/x/tools across these versions.

Run Details

98661 of 146368 relevant lines covered (67.41%)

2380.54 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	73.4	-2.13%	common/persistence/sql/sqlplugin/postgres/task.go
2	93.06	-1.39%	common/task/parallel_task_processor.go
2	80.0	-3.33%	common/persistence/sql/sqlplugin/postgres/db.go
2	52.41	-0.13%	service/history/handler/handler.go
2	73.23	-1.57%	service/matching/db.go
2	72.7	-0.13%	service/history/task/transfer_active_task_executor.go
2	91.78	-0.3%	common/util.go
2	79.7	-0.51%	service/matching/taskListManager.go
3	50.46	-0.55%	common/log/tag/tags.go
4	83.51	-1.03%	common/task/fifo_task_scheduler.go
4	61.98	-0.06%	service/frontend/api/handler.go
5	84.08	-0.8%	service/matching/taskReader.go
5	85.57	-0.52%	service/history/task/fetcher.go
6	87.01	-1.24%	service/history/task/transfer_standby_task_executor.go
8	80.79	-2.44%	service/history/task/cross_cluster_task_processor.go
9	68.43	-0.31%	service/history/engine/engineimpl/historyEngine.go
20	70.57	-5.71%	service/history/task/task_util.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	018eedc4-642b-49ce-be74-b8649f645074.1	17 Apr 2024 08:56PM UTC	673	67.41

uber / cadence / 018eedc4-642b-49ce-be74-b8649f645074
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 018eedc4-642b-49ce-be74-b8649f645074

uber / cadence / 018eedc4-642b-49ce-be74-b8649f645074 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 018eedc4-642b-49ce-be74-b8649f645074

uber / cadence / 018eedc4-642b-49ce-be74-b8649f645074
72%

README BADGES
x