rust-bitcoin / rust-bitcoin / 8725922851

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#2684: Allow m prefix in derivation paths

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b7f61e244257e16ac9754c906f9c4aaa7c6612f0">b7f61e244 Allow m prefix in derivation paths (Tobin C. Harding)

Pull request description:

  This PR contains a single patch that was created using `cargo cherry-pick 830c1e9c` - i.e., it is a backport of #2677.

  ----

  Recently in #2451 we disallowed bip32 derivation paths with the leading 'm' variable.

  There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call `getaddressinfo` returns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says.

  Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'.

  Leave the full investigation of the bip to a later date.

  Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.

ACKs for top commit:
  apoelstra:
    ACK b7f61e244257e16ac9754c906f9c4aaa7c6612f0 confirmed that diff exactly matches 2451. CI failure is unrelated.

Tree-SHA512: 075e8a7d35e022ac15c397a663090950f41

37 of 37 new or added lines in 1 file covered. (100.0%)

19193 of 23090 relevant lines covered (83.12%)

16791.07 hits per line