ooni / probe-cli / 8718750906

72%

push

github

feat(enginenetx): test `bridgesPolicy` with DNS success (#1554)

This diff introduces a test case for `bridgesPolicy` where we count
after how many policies we observe a DNS-generated policy. This test has
been crucial to investigate https://github.com/ooni/probe/issues/2704.
Based on this test we can conclude the following:

1. if the bridge IP address gets blocked or stops working, we're still
falling back to using the DNS;
2. however, the current algorithm does that in a too-slow fashion.

Additionally, I manually verified that we're actually falling back to
the DNS and that it really takes a long time by changing the
implementation to use `10.0.0.1` as the bridge address and verifying
that the code behaves as expected (though the "expected" behavior here
is not nice at all and we should improve upon that).

While there, fix naming and comments.

12 of 12 new or added lines in 4 files covered. (100.0%)

26295 of 31760 relevant lines covered (82.79%)

51.88 hits per line