openSUSE / agama / 8704867901

72%

push

github

web: Use meaningful icons in Storage proposal page (#1152)

During the presentation of #1138, it was seen that the _shadow_ icon
chosen for some of the actions opening a dialog created confusion in
some attendees when other no-iconized actions opened a dialog too.

Somehow, it was forgotten one of the principles followed in the Agama UI
until now: an action (link, button, button dressed up as a link, menu
item, etc) should be easily recognizable by users as an element they can
interact with in the way they use to do it. I.e., it's not needed to
identify if the action opens a dialog, navigates to another page, to
another section of the same page, opens a menu, shows or hides a
sidebar, etc, since the same action that today opens a dialog in the
future might navigate to another page instead.

Proposed changes here fix the issue by replacing these icons with ones
that represent the concept of the action or by none when it would hamper
more than help. **Keep in mind that icons are merely cosmetic aids for
sight people, reason why the meaning of the actions must not be
determined by them**. The UI must still be meaningful if, for whatever
reason, icons disappear.

Of course, the ones proposed here can be changed at any point when
better suggestions arise. **But remember that at this moment we're
mainly relying on https://fonts.google.com/icons**. We can change our
mind in the future, but choosing a consistent library of icons instead
of grabbing them from here and there. For example, [Lucid
icons](https://lucide.dev/icons/) could be a good candidate for a
library replacement, but in a future **PLEASE**.

1840 of 2684 branches covered (68.55%)

Branch coverage included in aggregate %.

18261 of 24183 relevant lines covered (75.51%)

31.52 hits per line