libcgroup / libcgroup / 8694963308

56%

Build Type

push

github

Committed by drakenclimber

Commit Message

fix: cgroupv2_subtree_control_recursive(): test before writing

cgroupv2_subtree_control_recursive() writes to subtree_control
files in the cgroup tree, starting at the root cgroup. As the
root cgroup is managed by SystemD, its control files belong to the
root user.
This new check ensures that we only attempt to write to subtree_control
if the desired controller is not already active (e.g., because we're
using SystemD Delegation mechanisms), thus better enabling cgroup
manipulations for non-root users.

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Run Details

5 of 6 new or added lines in 1 file covered. (83.33%)

2 existing lines in 2 files now uncovered.

5814 of 9580 relevant lines covered (60.69%)

1612.93 hits per line