stacklok / minder / 8691373785

53%

Build Type

push

github

Committed by web-flow

Commit Message

Ignore description and defaults when validing ruletype updates (#3092)

We've been doing a bunch of changes to the defaults and descriptions to
make UI render better, but those are being flagged by minder ruletype
apply as incompatible because we require that the new ruletype is a
strict superset of the old one.

Let's ignore the description field as long as it's a scalar with a string
value and let's ignore the default field as long as it has a 'type'
sibling. These additional checks make sure that we don't accidentally
allow updating parameters that are named default or description.

Fixes: https://github.com/stacklok/minder/issues/3079

Run Details

48 of 58 new or added lines in 1 file covered. (82.76%)

2 existing lines in 1 file now uncovered.

8287 of 17227 relevant lines covered (48.1%)

37.44 hits per line