ovn-org / ovn-kubernetes / 8688780191

53%

Build Type

push

github

Committed by jcaamano

Commit Message

Fix endpoint selection for externalTrafficPolicy=local

Fix the case for "all endpoints terminating on a node when traffic policy is local":
"When the traffic policy is "Local" and all endpoints are terminating within a single node, then traffic should be routed to any terminating endpoint that is ready on that node."
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1669-proxy-terminating-endpoints/README.md#example-all-endpoints-terminating-on-a-node-when-traffic-policy-is-local

The endpoint selection logic in the services controller is now entirely implemented in getEndpointsForService, which computes for a given service and each service port all its cluster-wide endpoints and per-node local endpoints. We first apply a cluster-wide vs local endpoint selection and only then we apply readiness-based filtering with getEligibleEndpointAddresses.

Added unit tests for the new logic.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>

Coverage Stats

216 of 227 new or added lines in 4 files covered. (95.15%)

25 existing lines in 6 files now uncovered.

27389 of 52278 relevant lines covered (52.39%)

92.93 hits per line