ben-manes / caffeine / #4437

100%

Build Type

push

github

Committed by ben-manes

Commit Message

Fix contains key for the async cache's synchronous view when in-flight (fixes #1626)

The keySet and its iterator will now suppress in-flight entries for
the contains test and by its iterator. The retain and removal methods
will discard in-flight mappings, like the entrySet view does. This is
intentional as it is better to overly discard data then keep stale
contents due to incorrect linearization assumptions (of which async can
offer few). The synchronous views are best-effort, lenient, and try to
match a user's likely expected or intended behavior while being
conservative by being cautiously safe. Thus, small leaks of in-flight
behavior is preferrable, especially given the concurrent nature of the
use-case, and we encourage using the async asMap view when
orchastrating more nuanced behavior.

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

7593 of 7669 relevant lines covered (99.01%)

0.99 hits per line