source-academy / backend / 3cf8d7d4832e7e887a48529ddcb4b2f332c02d3e

89%

Build Type

push

github

Committed by web-flow

Commit Message

Add Publish Grading Feature (#965)

* Add migrations to create is_grading_published column for submissions

Current submissions will have the is_grading_published field populated
as `true` if all answers have been graded i.e. have a grader_id, while
the rest will default to `false`.

Future submissions will have the field with default value `false` upon
creation.

* Add and update endpoints for new publish grading feature

- Update existing endpoints and queries related to assessment retrieval
- Add new routes and endpoints to handle new publish grading feature
- Add notification for new feature

* Fix missing return tuple values in assessments.ex

* Fix notification and formatting

* Fix indentation and minor error

* Fix formatting

* fix formatting

* fix credo long line

* fix credo nesting alias

* Fix formatting and code quality

* Fix tests

* feat: Implement format helper function

Changing xp in the assessment_with_questions_and_answers is the wrong direction,
I feel that the function should not be tied to a specific format. Instead,
I will call a helper function in the controller to format the xp.

* feat: Add formatting function for getting all assessments

* fix: Fix bug of using virtual variable instead

* refactor: Remove default value for virtual variable is_grading_published

* feat: Implement tests for helper functions

* feat: Add isGradingPublished to response for fetching all assessments

* refactor: Format

* chore: Remove unused match

* feat: Implement tests for unpublish route

* feat: Implement tests for publish route

* refactor: Move repeated code into setup for publish test

* refactor: Move repeated code into setup for unpublish test

* refactor: Format code

* feat: Add a guard to prevent unsubmit when grade is still published

* feat: Implement filter by notPublished

* refactor: Format

* fix: Fix incorrect guard check for is_grading_published

* ref... (continued)

Run Details

131 of 139 new or added lines in 7 files covered. (94.24%)

2 existing lines in 1 file now uncovered.

2996 of 3143 relevant lines covered (95.32%)

1002.96 hits per line