rust-bitcoin / rust-bitcoin / 8646648124

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2676: Improve deprecation notice

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/33ebbac4c8ead67243131e6e8ad4f25d0796af6d">33ebbac4c Improve deprecation notice (Tobin C. Harding)

Pull request description:

  The deprecation notice for `is_provably_unspendable` contains "is not very useful" which is a bit presumptuous to tell to users, it may very well be useful to them. Use the more helpful text that already exists in rustdoc on the function.

  Function was deprecated in #2294

ACKs for top commit:
  apoelstra:
    ACK 33ebbac4c8ead67243131e6e8ad4f25d0796af6d I am fine with the existing text
  sanket1729:
    utACK 33ebbac4c8ead67243131e6e8ad4f25d0796af6d

Tree-SHA512: 0611b9c41a7133bc7913f426cbcd8f56d5f

19189 of 23084 relevant lines covered (83.13%)

16840.08 hits per line