igniterealtime / Smack / #3068

40%

master: 40%

Build Type

push

github

Committed by guusdk

Commit Message

[sinttest] Refactoring XEP-0045 test for default roles

When testing for default role assignment based on affiliation, depending on the 'adminGranted' callback is dangerous, as this callback appears to be only invoked when the affected occupant has already joined the room.

The exact occupant count isn't something that these tests need to assert either.

This commit changes the test implementations to proceed when all expected occupants have been detected by the user performing the change.

For esthetic reasons, the invocations that make users join a room, and those that change affiliations for users have been grouped.

These changes combined intend to make the tests more robust, with regards to the order in which several events are fired (which might be unexpeced, given threading implementation in server (clusters) and Smack stanza handling.

Run Details

0 of 28 new or added lines in 1 file covered. (0.0%)

9 existing lines in 2 files now uncovered.

16922 of 42756 relevant lines covered (39.58%)

0.4 hits per line