safe-global / safe-modules / 8628743470

85%

master: 85%

Build Type

Pull #376

github

Committed by nlordell

Commit Message

Add NatSpec Documentation To The Safe Launchpad

Related to #308

This PR adds NatSpec documentation to the `SafeSignerLaunchpad` contract
for all methods. This is done in preparation for an auditing these
contracts and as a precursor to getting 100% test coverage.

In writing this PR, I found some issues with the current launchpad
implementation that need to be addressed pre-audit:
- We allow accounts that haven't been properly initialized, which can be
  a security risk. We should do checks similar to the Safe `setup`
  method to prevent double initialization and the validation should
  revert if the account is not initialized.
- We are using revert messages instead of errors.

Additionally, I would like to suggest that we change the implementation
to use a **single** setup instead of doing a pre- and post- setup
delegatecall. This would greatly simplify the implementation and
security assumptions of the launchpad. The downside is that the setup
cannot break 4337 rules, but we do not have a use-case for this, so I
wouldn't implement it.

Pull Request Pull Request #376: Add NatSpec Documentation To The Safe Launchpad

Coverage Stats

28 of 42 branches covered (66.67%)

Branch coverage included in aggregate %.

13 of 15 new or added lines in 1 file covered. (86.67%)

1 existing line in 1 file now uncovered.

94 of 101 relevant lines covered (93.07%)

9.26 hits per line