PHPCSStandards / PHP_CodeSniffer / 8616918426

78%

master: 79%

push

github

Squiz/ClosingDeclarationCommentSniff: prevent non-problematic bug

This commit fixes a non-problematic bug on line 96. The code `if
(rtrim($tokens[$next]['content']) === $comment)` was not taking into
account that `$next` can be false. To fix it, a `$next !== false` check
was added to the if condition.

This problem did not cause any issues because when `$next` is `false`, the
code would check the content of the first token
(`$tokens[0]['content']`) and this token can only be the PHP open tag or
inline HTML. The code would only produce false positives if the content
of the first token would be `// end ...` which is unlikely and would be
invalid HTML.

A test was added exercising the code path where `$next` is `false`.

And another tests which actually hits the bug and safeguards against potential regressions for the
non-problematic bug fix.

1 of 1 new or added line in 1 file covered. (100.0%)

17363 of 23994 relevant lines covered (72.36%)

55.29 hits per line