• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In
Build has been canceled!

uber / cadence / 018ebfb4-5229-4385-9145-795edac4f8a7
72%

Build:
DEFAULT BRANCH: master
Ran 08 Apr 2024 10:13PM UTC
Jobs 1
Files 674
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Apr 2024 09:54PM UTC coverage: 67.352% (-0.001%) from 67.353%
018ebfb4-5229-4385-9145-795edac4f8a7

push

buildkite

web-flow
Notify named subscribers for membership changes (#5823)

**What changed?**
Notify "named" membership change subscribers

**Why?**
There are two levels of membership change notification mechanisms. One is per-service (frontend, history, etc), another one is for services to use in their internal components (like shard controller in history service).

For service-level subscribers, there was a missing piece of code to send notification on registered channel. As this is a bug, automatic 10s interval refresh helped to mitigate this bug. Now service-level subscribers will be informed immediately. 

**How did you test it?**
Added unit test to check if notifications are sent when receiving message from "peer provider" (ringpop for example)

27 of 30 new or added lines in 1 file covered. (90.0%)

38 existing lines in 6 files now uncovered.

98175 of 145763 relevant lines covered (67.35%)

2358.24 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
85.65
2.4% common/membership/hashring.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
87.42
0.82% service/history/task/transfer_standby_task_executor.go
2
84.88
0.8% service/matching/taskReader.go
2
66.67
-0.5% common/persistence/historyManager.go
3
96.07
-1.07% common/persistence/statsComputer.go
5
82.47
-5.15% common/task/fifo_task_scheduler.go
24
56.65
-7.59% service/history/execution/mutable_state_task_refresher.go
Jobs
ID Job ID Ran Files Coverage
1 018ebfb4-5229-4385-9145-795edac4f8a7.1 08 Apr 2024 10:13PM UTC 674
67.35
Source Files on build 018ebfb4-5229-4385-9145-795edac4f8a7
  • Tree
  • List 674
  • Changed 279
  • Source Changed 0
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 3e05f2c9 on github
  • Prev Build on master (#018EBFA1...)
  • Next Build on master (#018EC2B7...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc