uber / cadence / 018ebf75-d896-4006-833e-63db25b11019

72%

Build Type

push

buildkite

Committed by web-flow

Commit Message

persistence/client/factory.go test coverage (#5859)

Our ability to cover this file is rather harshly limited due to it directly calling funcs in other packages that try to make network connections... but thankfully the DataStore-based stuff can be intercepted.  So I've at least tested those branches.

More generally this package is yet another strong argument in favor of leaning more on go.uber.org/fx for dependency injection.  Very little of this has to be (or should be) hard-coded in this file.  It feels like Java's "Service Locator" pattern, but even worse because the language doesn't allow test controls of globals like Java does... so I doubt it's a coincidence that there's a `bean.go` file in here.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

70 existing lines in 12 files now uncovered.

98115 of 145751 relevant lines covered (67.32%)

2395.27 hits per line