ooni / probe-cli / 8552629877

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: move Saver, Submitter, and InputProcessor to oonirun (#1543)

My current objective is to cleanup and rationalize the engine package
such that it is more explicit how we're using probeservices APIs.

In performing this task, I noticed that Saver and InputProcessor are
only ever used by the oonirun package.

This happens because:

1. the Saver is just a tiny wrapper around SaveMeasurement that
constructs either a model.Saver or a fake one depending on the
configuration, which seems a pretty specific use case of oonirun given
the current API we're using;

2. we can same basically the same for the Submitter;

3. the InputProcessor, albeit nice, is probably not flexible enough to
be used elsewhere unless we hammer it a lot.

Additionally, in the future, ./cmd/ooniprobe should probably be based on
oonirun, and possibly also ./pkg/oonimkall.

Also, ./internal/cmd/miniooni is already based on oonirun.

To conclude, oonirun should be the focus of future work and changes,
while the functionality I'm moving here, could either be in engine or
oonirun. But my current goal is to focus on the engine, so it's fine to
move these types.

Part of https://github.com/ooni/probe/issues/2700

Run Details

49 of 50 new or added lines in 5 files covered. (98.0%)

5 existing lines in 2 files now uncovered.

26076 of 31686 relevant lines covered (82.3%)

53.04 hits per line