8548419439
96%
3.x: 98%

Ran 04 Apr 2024 02:28AM CUT

Jobs 23

Files 41

Run time 174min

Badge

Embed ▾

Committed 04 Apr 2024 02:28AM CUT coverage: 96.232% (-1.0%) from 97.254%

Build # 8548419439

Build Type

push

github

Committed by

jrfnl

Commit Message

Tests: minor tweaks to work round PHP 8.4 deprecation

PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable.

The `ValueObject` fixture used in these tests used one such implicitly nullable parameters.

The tests for the `AssertObjectEquals` trait already needed two test classes to allow the method to be fully tests cross-version:
* One set which was run on PHPUnit < 9.4.0.
* One set which runs against PHP 7.0+.

As the nullability operator was introduced in PHP 7.1 and the particular test affected _does_ need to be typed to still test what it is supposed to test, I'm changing the requirements both test sets:
* The requirement for the first set of tests will now be PHPUnit < 9.4.0 AND PHP < 8.4.
* The requirement for the second set of test will now be PHP 7.1+.

This way the tests still covers the trait sufficiently.

_Note: the trait itself is not affected by the deprecation._

Run Details

664 of 690 relevant lines covered (96.23%)

60.9 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
7	91.49	-7.47%	src/Polyfills/AssertObjectEquals.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	php-7.4-phpunit-8.1.6 - 8548419439.1	04 Apr 2024 02:28AM CUT	41	43.9	GitHub Action Run
2	php-5.4-phpunit-auto - 8548419439.2	04 Apr 2024 02:28AM CUT	41	68.99	GitHub Action Run
3	php-7.2-phpunit-6.3.1 - 8548419439.3	04 Apr 2024 02:28AM CUT	41	61.98	GitHub Action Run
4	php-7.3-phpunit-7.2.7 - 8548419439.4	04 Apr 2024 02:28AM CUT	41	61.54	GitHub Action Run
5	php-7.1-phpunit-auto - 8548419439.5	04 Apr 2024 02:28AM CUT	41	43.46	GitHub Action Run
6	php-8.0-phpunit-9.3.0 - 8548419439.6	04 Apr 2024 02:28AM CUT	41	30.87	GitHub Action Run
7	php-8.3-phpunit-auto - 8548419439.7	04 Apr 2024 02:28AM CUT	41	8.66	GitHub Action Run
8	php-5.5-phpunit-auto - 8548419439.8	04 Apr 2024 02:28AM CUT	41	68.99	GitHub Action Run
9	php-8.1-phpunit-auto - 8548419439.9	04 Apr 2024 02:28AM CUT	41	8.66	GitHub Action Run
10	php-8.3-phpunit-9.3.0 - 8548419439.10	04 Apr 2024 02:28AM CUT	41	30.69	GitHub Action Run
11	php-8.1-phpunit-9.3.0 - 8548419439.11	04 Apr 2024 02:28AM CUT	41	30.87	GitHub Action Run
12	php-7.4-phpunit-auto - 8548419439.12	04 Apr 2024 02:28AM CUT	41	9.75	GitHub Action Run
13	php-7.3-phpunit-auto - 8548419439.13	04 Apr 2024 02:28AM CUT	41	9.75	GitHub Action Run
14	php-7.0-phpunit-auto - 8548419439.14	04 Apr 2024 02:28AM CUT	41	50.89	GitHub Action Run
15	php-5.6-phpunit-auto - 8548419439.15	04 Apr 2024 02:28AM CUT	41	51.4	GitHub Action Run
16	php-8.0-phpunit-auto - 8548419439.16	04 Apr 2024 02:28AM CUT	41	8.66	GitHub Action Run
17	php-7.2-phpunit-auto - 8548419439.17	04 Apr 2024 02:28AM CUT	41	34.45	GitHub Action Run
18	php-5.6-phpunit-5.7.21 - 8548419439.18	04 Apr 2024 02:28AM CUT	41	51.4	GitHub Action Run
19	php-7.0-phpunit-5.7.27 - 8548419439.19	04 Apr 2024 02:28AM CUT	41	51.33	GitHub Action Run
20	php-7.1-phpunit-5.7.21 - 8548419439.20	04 Apr 2024 02:28AM CUT	41	61.54	GitHub Action Run
21	php-8.2-phpunit-9.3.0 - 8548419439.21	04 Apr 2024 02:28AM CUT	41	30.69	GitHub Action Run
22	php-7.4-phpunit-9.6.10 - 8548419439.22	04 Apr 2024 02:28AM CUT	41	18.95	GitHub Action Run
23	php-8.2-phpunit-auto - 8548419439.23	04 Apr 2024 02:28AM CUT	41	8.66	GitHub Action Run

Source Files on build 8548419439

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
77.78	...s/TestListenerDefaultImplementationPHPUnitLte5.php	154	27	21	6	13.0
85.71	...ners/TestListenerDefaultImplementationPHPUnit6.php	147	28	24	4	5.0
85.71	...s/TestListenerDefaultImplementationPHPUnitGte7.php	147	28	24	4	28.0
90.0	src/Helpers/ResourceHelper.php	143	40	36	4	308.0
91.49	src/Polyfills/AssertObjectEquals.php	233	94 - 2	86 - 9	8 + 7	62.0 - 68
100.0	...rc/Polyfills/AssertEqualsSpecializations_Empty.php	0	0	0	0	0.0
100.0	src/Polyfills/AssertClosedResource.php	78	22	22	0	247.0
100.0	src/Exceptions/TypeError.php	0	0	0	0	0.0
100.0	src/Polyfills/AssertFileDirectory.php	260	86	86	0	4.0
100.0	src/Polyfills/AssertFileDirectory_Empty.php	0	0	0	0	0.0

96.23
src/

Yoast / PHPUnit-Polyfills / 8548419439
96%
3.x: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8548419439

Yoast / PHPUnit-Polyfills / 8548419439 96% 3.x: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8548419439

Yoast / PHPUnit-Polyfills / 8548419439
96%
3.x: 98%

README BADGES
x