• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ooni / probe-cli / 8533780978
72%

Build:
DEFAULT BRANCH: master
Ran 03 Apr 2024 05:41AM UTC
Jobs 1
Files 542
Run time 44min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Apr 2024 05:36AM UTC coverage: 82.209% (-0.008%) from 82.217%
8533780978

push

github

web-flow
cleanup(engine): do not expose LookupLocationContext (#1537)

Potentially, this code would cause a behavioral change in that once the
probe location has been found, it would not change again and it might be
a problem for very-long-running sessions.

However:

1. the Android codebase does not keep a reference to a session for a
very long time and anyway the longest-running sessions are those used
for running experiments;

2. the correct behavior would be for MaybeLookupLocationContext to cache
the results only for a limited amount of time.

Because of all these considerations, it actually makes sense to say that
replacing LookupLocationContext with MaybeLookupLocationContext and
engine.Session accessors is the ~same.

The net benefit for us is that we can further reduce the surface of
interaction between clients and the engine code. A simpler API surface
is also simpler to document.

Part of https://github.com/ooni/probe/issues/2700

0 of 10 new or added lines in 2 files covered. (0.0%)

5 existing lines in 2 files now uncovered.

26048 of 31685 relevant lines covered (82.21%)

52.55 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 8533780978.1 03 Apr 2024 05:41AM UTC 0
82.21
GitHub Action Run
Source Files on build 8533780978
Detailed source file information is not available for this build.
  • Back to Repo
  • f9cb93ee on github
  • Prev Build on master (#8533206761)
  • Next Build on master (#8534101917)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc