ooni / probe-cli / 8533780978

72%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup(engine): do not expose LookupLocationContext (#1537)

Potentially, this code would cause a behavioral change in that once the
probe location has been found, it would not change again and it might be
a problem for very-long-running sessions.

However:

1. the Android codebase does not keep a reference to a session for a
very long time and anyway the longest-running sessions are those used
for running experiments;

2. the correct behavior would be for MaybeLookupLocationContext to cache
the results only for a limited amount of time.

Because of all these considerations, it actually makes sense to say that
replacing LookupLocationContext with MaybeLookupLocationContext and
engine.Session accessors is the ~same.

The net benefit for us is that we can further reduce the surface of
interaction between clients and the engine code. A simpler API surface
is also simpler to document.

Part of https://github.com/ooni/probe/issues/2700

Run Details

0 of 10 new or added lines in 2 files covered. (0.0%)

5 existing lines in 2 files now uncovered.

26048 of 31685 relevant lines covered (82.21%)

52.55 hits per line