uber / cadence / 018ea09a-e4f5-4af7-b8c3-8cd2b97b296f
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 674
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.766% (+0.2%) from 65.553%
018ea09a-e4f5-4af7-b8c3-8cd2b97b296f

push

buildkite

web-flow 
add unit test for history client (#5841)

What changed?

Added unit test
Refactored PeerResolver to interface for easier testing
Why?

improve test coverage

5 of 6 new or added lines in 1 file covered. (83.33%)

53 existing lines in 15 files now uncovered.

96242 of 146339 relevant lines covered (65.77%)

2410.63 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
65.12
 0.0% client/history/peerResolver.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
77.62
 -0.21% service/history/queue/timer_queue_processor_base.go
1
91.07
 -0.34% service/matching/matcher.go
2
89.05
 0.0% common/task/weighted_round_robin_task_scheduler.go
2
83.54
 -0.25% common/persistence/execution_manager.go
2
87.63
 0.0% common/task/fifo_task_scheduler.go
2
91.78
 -0.3% common/util.go
2
79.7
 -0.51% service/matching/taskListManager.go
2
78.13
 -0.52% service/history/execution/mutable_state_util.go
2
82.23
 -1.02% common/membership/hashring.go
2
97.14
 0.36% common/persistence/statsComputer.go
3
95.83
 -2.5% service/history/queue/timer_gate.go
3
85.57
 0.52% service/history/task/fetcher.go
4
69.43
 -1.14% service/history/task/task_util.go
11
66.7
 -0.94% service/history/shard/context.go
14
68.08
 -1.41% service/history/execution/context.go
Jobs
ID Job ID Ran Files Coverage
1 018ea09a-e4f5-4af7-b8c3-8cd2b97b296f.1 674
65.77
Source Files on build 018ea09a-e4f5-4af7-b8c3-8cd2b97b296f