containerbuildsystem / cachi2 / 8521358557

97%

push

github

interface: cli: Remove the top-level deps subdirectory before fetching

We keep reusing the old output directory hierarchy with repeated fetch
runs, overwriting all relevant files. Right now it's all fine because
all the files have predictable (pretty much fixed) names, however if we
create files/directories with any randomness in their names, we'll be
just creating more and more noise with repeated runs. Since we're
rewriting all files for the processed package managers anyway (for now),
i.e. not reusing data in between runs, it would be better if we first
cleaned up the destination if it exists and only then proceed with the
fetch. However, by the nature of the '--output' CLI option this very
well can be $HOME so we can't delete the top-level output directory,
but only its closest known subdirectory, i.e. 'deps'.

This is far from ideal as we'd still leave around files like bom.json
and potentially other files dirtying the underlying base directory.
This behaviour ill need to be addressed in the future, though it might
possibly eventually lead to backwards incompatible behaviour. For now
though, this quick fix will have to do.

Note that failing to process a request with an error message would be
the preferred approach if the output directory existed, because we
can't be sure that the existing directory we're being pointed to was
indeed created by us so we may end up deleting other legitimate data
(see above for the problem with e.g. $HOME), however, given that such
logic would lead to regressive behaviour since we already happily
overwrite anything the user points us at, what is being proposed here
isn't any worse than it already is.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

3315 of 3395 relevant lines covered (97.64%)

2.93 hits per line