blues / note-c / 8513310738

93%

push

github

fix: when sending unsupported requests to a notecard, don't wastefully retry (#142)

* fix: when sending unsupported requests to a notecard, don't wastefully retry

Notecards of all types, when they get an unrecognized request, return both {io} and {not-supported} in their err field.

This is because the notecard has no idea whether the request type is corrupted because of bad I/O, or because it is not supported.

As such, when a host app innocently does a card.wireless expecting to get a {not-supported} error, it takes ten seconds or more to get the failure because it is retrying it over and over because of the {io}.

Although non-zero, the reality is that there is lower chance of it being an {io} error if in fact {not-supported} is found.

As such, I've opted to not do retries if that specific error comes back.

* Tweak Ray's changes to handle "not supported" errors.

- Fix a compilation error (missing parenthesis).
- Add unit tests for NoteRequestResponseWithRetry. I had these sitting on my
machine locally and never pushed them. I added a test that checks the behavior
around "not supported" errors.
- Add a unit test to NoteTransaction_test.cpp around "not supported" errors.

* astlye

---------

Co-authored-by: Hayden Roche <hroche@blues.com>

1003 of 1231 branches covered (81.48%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2131 of 2259 relevant lines covered (94.33%)

81.23 hits per line